Re: [PATCH] gnu: Add inklingreader

[Roel Janssen]

0001-gnu-Add-inklingreader-v2.patch
Description: Text Data

Hi Mathieu,

Thanks for your reply.

Mathieu Lirzin writes:

>>>From 7cd292fdb46637858e4eaedd3570b607b5087720 Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <address@hidden>
>> Date: Tue, 10 Nov 2015 15:01:33 +0100
>> Subject: [PATCH] gnu: Add inklingreader
>>
>> * gnu-system.am: Add the package to GNU_SYSTEM_MODULES.
>> * gnu/packages/inklingreader.scm: The package description.
>
> Guix has somekind of "template" commit log when adding packages, you
> will find multiple examples with
>
>   git log --grep="(GNU_SYSTEM_MODULES): Add it"
>
> When applying it to your package you will obtain this.
>
> --8<---------------cut here---------------start------------->8---
> gnu: Add inklingreader.
>
> * gnu/packages/inklingreader.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> --8<---------------cut here---------------end--------------->8---

Fixed.

>> ---
>>  gnu-system.am                  |  1 +
>>  gnu/packages/inklingreader.scm | 65 
>> ++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 66 insertions(+)
>>  create mode 100644 gnu/packages/inklingreader.scm
> [...]
>> +++ b/gnu/packages/inklingreader.scm
>> @@ -0,0 +1,65 @@
>> [...]
>> +    (arguments `(#:configure-flags '("--enable-silent-rules")))
>
> this is automatically done, so this flag is not needed.

Fixed.

>> +    (inputs
>> +     `(("glib" ,glib)
>> +       ("cairo" ,cairo)
>> +       ("librsvg" ,librsvg)
>> +       ("gtk+" ,gtk+)
>> +       ("libusb" ,libusb)
>> +
>> +       ;; Needed to build the package.
>> +       ("texinfo" ,texinfo)))
>
> Actually the documentation is not built so I don't think this is needed.
> If you want to easily provide the documentation to Guix you will need to
> add the Automake variable "info_TEXINFOS" in you Makefile.am file in the
> next release, see:
>
>   https://www.gnu.org/software/automake/manual/automake.html#Texinfo

Fixed.

>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)))
>> +
>> +    (home-page "http://savannah.gnu.org/projects/inklingreader/";)
>
> I think It would be better to provide
>
>   https://www.gnu.org/software/inklingreader/

Fixed.

> Can you send an updated patch?

I attached it.

Thanks for your time,
Roel Janssen