Re: wip-refactor-emacs-ui and Hydra interface

[Alex Kost]

Ludovic Courtès (2015-12-22 00:16 +0300) wrote:

> Alex Kost <address@hidden> skribis:
>
>> Ludovic Courtès (2015-12-18 01:23 +0300) wrote:
[...]
>>> I haven’t looked at the code yet, but it’s your area of expertise and
>>> I’m confident.  :-)  I skim over it when you think it’s ready; are there
>>> parts you’d like to be reviewed more carefully?
>>
>> Well, I always feel uncomfortable with commit messages.  But I think the
>> main part that should be reviewed is documentation (in commit 731f5e4).
>
> So, regarding the documentation:
>
>   address@hidden Emacs Hydra
>   address@hidden Hydra
>   +
>   +Guix also provides an interface for @code{hydra.gnu.org} (Guix build
>   +farm) that allows to display Hydra builds and jobsets.  This interface
>   +is mostly the same as the ``list''/``info'' interface for displaying
>   +packages and generations (@pxref{Emacs Package Management}).
>
> I would suggest adding a bit of context, like this:
>
>   The continuous integration server at @code{hydra.gnu.org} builds all
>   the distribution packages on the supported architectures and serves
>   them as substitutes (@pxref{Substitutes}).  Continuous integration is
>   currently orchestrated by @uref{https://nixos.org/hydra/, Hydra}.
>
>   This section describes an Emacs interface to query Hydra to know the
>   build status of specific packages, discover recent and ongoing builds,
>   view build logs, and so on.  This interface is mostly the same as …
>
> WDYT?

Sure!

> I would also add a cross-reference like:
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 06d70ba..bf523aa 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -1568,7 +1568,9 @@ also result from derivation builds, can be available as 
> substitutes.
>  
>  The @code{hydra.gnu.org} server is a front-end to a build farm that
>  builds packages from the GNU distribution continuously for some
> -architectures, and makes them available as substitutes.  This is the
> +architectures, and makes them available as substitutes (@pxref{Emacs
> +Hydra}, for information on how to query the continuous integration
> +server).  This is the
>  default source of substitutes; it can be overridden by passing the
>  @option{--substitute-urls} option either to @command{guix-daemon}
>  (@pxref{daemon-substitute-urls,, @code{guix-daemon --substitute-urls}})

Great, I have fixed the commit locally for these documentation changes.

>>> Anyway, let me know what you think and how you’d like to proceed.
>>
>> OK, I have done some final changes and rebased the branch on master, so
>> (from my point of view) it is ready for merging.  Should I spam the list
>> with these (37) patches?
>
> I don’t think so.  :-)
>
> AFAICS only elisp code is touched, and the rest of the Emacs code is
> supposed to be functionally equivalent, right?

Yes, only elisp code for 'list'/'info' UI was touched.  I'm not sure
what "functionally equivalent" means.  For a user, there shouldn't be
any visible changes.  But the internals (I mean the code itself) was
changed completely.  There are also some changes in user variables (I'm
mentioning them in another message).

> I’m tempted to punt on this one and let you push the whole series.
> What do people think?

I agree with this proposal :-)

-- 
Alex