guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [v3 2/2] gnu: w3m: Enable SSL, disable broken protocols and ciphers.


From: Leo Famulari
Subject: Re: [v3 2/2] gnu: w3m: Enable SSL, disable broken protocols and ciphers.
Date: Thu, 7 Jan 2016 02:37:52 -0500
User-agent: Mutt/1.5.24 (2015-08-30)

On Wed, Jan 06, 2016 at 11:52:07AM +0100, Ludovic Courtès wrote:
> Leo Famulari <address@hidden> skribis:
> 
> > * gnu/packages/patches/w3m-force-ssl_verify_server-on.patch: New file.
> > * gnu/packages/patches/w3m-disable-sslv2-and-sslv3.patch: New file.
> > * gnu/packages/patches/w3m-disable-weak-ciphers.patch: New file.
> > * gnu/packages/w3m.scm (w3m)[source]: Add patches.
> > * gnu-system.am (dist_patch_DATA): Add the new files.
> 
> Please add:
> 
>   Fixes <http://bugs.gnu.org/16791>.

Done.

> 
> > +From 7b8d2dbc41b6bdab09e2e632e8481f6e8b585a42 Mon Sep 17 00:00:00 2001
> > +From: Leo Famulari <address@hidden>
> > +Date: Tue, 5 Jan 2016 17:15:33 -0500
> > +Subject: [PATCH 3/4] Disable SSLv2 and SSLv3.
> 
> I would remove the Git header from the patches (since they are from a
> local repository I guess?) and keep only the subject line and
> description.

Done.

> 
> Otherwise LGTM!

Pushed with the requested changes as e6352001c4 and 62339e2d49.

> 
> Thanks for working on one of the oldest bug reports.  :-)
> 
> Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]