Re: [PATCH] gnu: bind-utils: Build and install “nsupdate”.

[Mathieu Lirzin]

Ricardo Wurmus <address@hidden> writes:

> Okay.  Attached are three new patches.  I thought I should better split
> this up into separate commits for clarity.

Splitting thoses changes is a good idea.  Thanks for taking the time to
do it.

>>From b276ca4c3940663137e4449144b2256f03e47d27 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Thu, 21 Jan 2016 11:20:30 +0100
> Subject: [PATCH 1/3] gnu: bind-utils: Use "modify-phases" syntax.
>
> * gnu/packages/dns.scm (bind-utils): Use "modify-phases" syntax.

OK.

>>From 4c7f432edbd65abad749170a280d88181f533635 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Thu, 21 Jan 2016 11:41:10 +0100
> Subject: [PATCH 2/3] gnu: bind-utils: Generalize "build" and "install" phases.
>
> * gnu/packages/dns.scm (bind-utils)[arguments]: Generalize "build" and
>   "install" phases.

OK.

>>From 6bd7b2a30ef1f128097c2ff4030e465e3955a34f Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Thu, 21 Jan 2016 11:42:17 +0100
> Subject: [PATCH 3/3] gnu: bind-utils: Build and install "nsupdate".
>
> * gnu/packages/dns.scm (bind-utils)[arguments]: Also build and install
>   "nsupdate" executable.

I think “Also” can be removed here.  Otherwise LGTM.

Thanks,

--
Mathieu Lirzin