guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/04] gnu: Add python-pygpgme


From: Ludovic Courtès
Subject: Re: [PATCH 01/04] gnu: Add python-pygpgme
Date: Sat, 06 Feb 2016 13:55:35 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Leo Famulari <address@hidden> skribis:

> On Fri, Feb 05, 2016 at 07:47:26PM -0800, Christopher Allan Webber wrote:

[...]

>> +       ;; Unfortunately, we have to disable some tests due to some gpg-agent
>> +       ;; goofiness... see:
>> +       ;;   https://bugs.launchpad.net/pygpgme/+bug/999949
>> +       (patches (list (search-patch 
>> "pygpgme-disable-problematic-tests.patch")))))
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'build 'make-build
>> +             (lambda (. args)
>> +               (zero? (system* "make" "build"))))
>
> I'm not a Scheme expert, but I wonder about "lambda (.args)". Most of
> these calls to (system*) start with "lambda _". What is the difference
> here?

(lambda (. args) …) is equivalent to (lambda args …), meaning a
procedure that takes an unlimited number of arguments.

It’s a convention to use ‘_’ to denote unused variables, so we usually
write (lambda _ …) in such cases.

The lambda above is slightly two indented; perhaps the guix-devel Emacs
mode isn’t loaded?

>> +       ("gnupg" ,gnupg-2.0)
>
> Does it only work with gnupg-2.0? We also package the 2.1 series of
> GnuPG.

I think we should stick to 2.0, which is the latest stable version.

>> +       ("gpgme" ,gpgme)))
>> +    (home-page "https://launchpad.net/pygpgme";)
>> +    (synopsis
>> +     "A Python module for working with OpenPGP messages")
>
> This can all go on one line.

Also please remove “A” (I think ‘guix lint’ would complain.)

OK to push with these and Leo’s other comments addressed!

Thank you,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]