Re: [PATCH] gnu: Add pass.

[Ludovic Courtès]

Hi!

Jessica Tallon <address@hidden> skribis:

> From 86ab2ad8f47cb72780cf0140352a9a5c26af36f8 Mon Sep 17 00:00:00 2001
> From: Jessica Tallon <address@hidden>
> Date: Mon, 8 Feb 2016 22:12:50 +0100
> Subject: [PATCH] gnu: Add pass.
>
> * gnu/packages/password-utils.scm (pass): New variable.

[...]

> +(define-public pass
> +  (package
> +    (name "pass")

I think we should call it “password-store” since that’s the upstream
name.

> +       ;; The tests mysteriously hang, I've tired it outside of guix and
> +       ;; they run perfectly fine. Not sure why so for now I've disabled
> +       ;; them.
> +       #:tests? #f

I added ‘set -x’ to src/password-store.sh and run ‘make check’ within
‘guix environment --container’, which gave this:

--8<---------------cut here---------------start------------->8---
# ./src/password-store.sh init 000432
+ GPG_OPTS=("--quiet" "--yes" "--compress-algo=none" "--no-encrypt-to")
+ GPG=gpg
++ tty
+ export GPG_TTY=/dev/console
+ GPG_TTY=/dev/console
+ which gpg2
+ [[ -n '' ]]
+ [[ gpg == \g\p\g\2 ]]
+ PREFIX=/homeless-shelter/.password-store
+ X_SELECTION=clipboard
+ CLIP_TIME=45
+ export GIT_DIR=/homeless-shelter/.password-store/.git
+ GIT_DIR=/homeless-shelter/.password-store/.git
+ export GIT_WORK_TREE=/homeless-shelter/.password-store
+ GIT_WORK_TREE=/homeless-shelter/.password-store
+ GETOPT=getopt
+ SHRED='shred -f -z'
++ dirname ./src/password-store.sh
++ uname
++ cut -d _ -f 1
++ tr '[:upper:]' '[:lower:]'
+ source ./src/platform/linux.sh
+ PROGRAM=password-store.sh
+ COMMAND=init
+ case "$1" in
+ shift
+ cmd_init 000432
+ local opts id_path=
++ getopt -o p: -l path: -n password-store.sh -- 000432
./src/password-store.sh: line 263: getopt: command not found
+ opts=
+ local err=127
+ eval set -- ''
++ set --
+ true
+ case $1 in
+ true
+ case $1 in
[… endless loop…]
--8<---------------cut here---------------end--------------->8---

So I think adding util-linux (which provides the ‘getopt’ command) as an
input will solve the problem.

> +    (description "Pass is a password manager which uses gnupg to store, 
> retrieve
> +generated passwords.  The tool stores each password in its own file gpg
> +encrypted allowing the program to be simple yet secure.  Synchronization is
> +possible with inbuild git support which commits changes to your password 
> database
> +to a git repository that can be managed through the pass command.")

s/gnupg/GnuPG/; s/git/Git/; s/gpg/@command{gpg}/  :-)

Could you send an updated patch?

Thank you!

Ludo’.