guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Inherit inputs when unnecessary in these python2 packages?


From: Andreas Enge
Subject: Re: Inherit inputs when unnecessary in these python2 packages?
Date: Sun, 14 Feb 2016 15:48:32 +0100
User-agent: Mutt/1.5.24 (2015-08-30)

On Sat, Feb 13, 2016 at 06:10:17PM -0800, Christopher Allan Webber wrote:
> >     (native-inputs
> >      `(("python-setuptools-scm" ,python-setuptools-scm)))
> > 
> > (define-public python2-execnet
> >   (package
> >     (inherit (package-with-python2
> >               (strip-python2-variant python-execnet)))
> >     (inputs
> >      `(("python2-setuptools" ,python2-setuptools)))))
> 
> As you can see, there is no inputs on python-execnet, so it's not
> necessary to include the inputs.  However, if (inputs) were added in the
> future, this could lead to a developer mistakenly forgetting to change
> the python2 variant.

This looks suspicious; should the python2-setuptools not also be a
native input? Then accidentally the problem you mention would also
disappear.

Andreas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]