Re: [PATCH 1/18] gnu: Add python-mako.

[Leo Famulari]

On Mon, Feb 15, 2016 at 03:23:45PM -0800, Christopher Allan Webber wrote:
> First in a series of towards-MediaGoblin patches.

Awesome!

I'm reviewing these on the assumption that you've tested they all build.

> From ad76816977e98e0230ccde7475598e6e85de4d29 Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <address@hidden>
> Date: Fri, 12 Feb 2016 13:23:46 -0800
> Subject: [PATCH 01/18] gnu: Add python-mako.
> 
> * gnu/packages/python.scm (python-mako, python2-mako): New variables.
> ---
>  gnu/packages/python.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 805c4a2..5b7e4ac 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -7532,3 +7532,34 @@ available in Django, but is a standalone package.")
>      (inherit (package-with-python2
>                (strip-python2-variant python-wtforms)))
>      (inputs `(("python2-setuptools" ,python2-setuptools)))))
> +
> +(define-public python-mako
> +  (package
> +    (name "python-mako")
> +    (version "1.0.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "Mako" version))
> +       (sha256
> +        (base32
> +         "136kcjbs0s98qkx8a418b05dfblqp0kiiqyx8vhx4rarwc7bqi3n"))))
> +    (build-system python-build-system)
> +    (inputs
> +     `(("python-markupsafe" ,python-markupsafe)
> +       ("python-mock" ,python-mock)
> +       ("python-nose" ,python-nose)))

Are mock and nose required after build-time? If not, they should be
native-inputs.

As for markupsafe, the latest version of the manual has this to say
about propagated-inputs:

Another example where propagated-inputs is useful is for languages that
lack a facility to record the run-time search path akin to ELF’s
RUNPATH; this includes Guile, Python, Perl, GHC, and more. To ensure
that libraries written in those languages can find library code they
depend on at run time, run-time dependencies must be listed in
propagated-inputs rather than inputs. 

I won't mention these potential issues in my reviews of the rest of the
patches.

> +    (home-page "http://www.makotemplates.org/";)
> +    (synopsis
> +     "Fast templating language")
> +    (description
> +     "Mako is a Python string templating library.  Used frequently for
> +generating HTML.")
> +    (license license:expat)
> +    (properties `((python2-variant . ,(delay python2-mako))))))
> +
> +(define-public python2-mako
> +  (package
> +    (inherit (package-with-python2
> +              (strip-python2-variant python-mako)))
> +    (inputs `(("python2-setuptools" ,python2-setuptools)))))

Setuptools is a native-input.

> -- 
> 2.6.3
>