Re: [PATCH 1/1] gnu: diffoscope: Update to 49.

[Ricardo Wurmus]

Leo Famulari <address@hidden> writes:

> * gnu/packages/package-management.scm (diffoscope): Update to 49.
> [source]: Use pypi-uri.
> [arguments]: Use python-3. Enable tests. Add 'dependency-on-python-magic' 
> phase
> and remove 'dependency-on-rpm' phase.
> ---
[...]
>      (inputs `(("rpm" ,rpm)                        ;for rpm-python
> -              ("python-file" ,python2-file)
> -              ("python-debian" ,python2-debian)
> -              ("python-libarchive-c" ,python2-libarchive-c)
> -              ("python-tlsh" ,python2-tlsh)
> +              ("python-file" ,python-file)
> +              ("python-debian" ,python-debian)
> +              ("python-libarchive-c" ,python-libarchive-c)
> +              ("python-tlsh" ,python-tlsh)
>  
>                ;; Below are modules used for tests.
> -              ("python-pytest" ,python2-pytest)
> -              ("python-chardet" ,python2-chardet)))
> -    (native-inputs `(("python-setuptools" ,python2-setuptools)))
> +              ("python-pytest" ,python-pytest)
> +              ("python-chardet" ,python-chardet)))
>      (home-page "http://diffoscope.org/";)
>      (synopsis "Compare files, archives, and directories in depth")
>      (description


Since you’re changing “inputs” and “native-inputs” you should mention
these changes in the commit summary.

Otherwise looks okay to me.

~~ Ricardo