|
| From: | Rob Syme |
| Subject: | Re: [PATCH] gnu: Include CodingQuarry gene predictor |
| Date: | Tue, 08 Mar 2016 23:41:43 +0000 |
Sure, I'll do that. Thanks for the feedback.
-r
On Tue, Mar 08, 2016 at 05:13:34PM +0800, Rob Syme wrote:
Thank you for the patch!
> * gnu/packages/bioinformatics.scm: Add codingquarry package description
When adding packages, we have a preferred format for the commit message.
It's either the GNU changelog format or a slightly modified version (I'm
not sure). You can see a good example in commit 0e2f2aebed.
[...]
> + (delete 'check) ;; Don't run the 'make check' step of the
> gnu-build-system
When skippping the tests, we prefer to say why in the comment. It can be
as simple as "no test suite" if that is the case.
[...]
> + (native-inputs `(("python", python-2)))
If the software only works with Python 2, I prefer to say so in a
comment such as "Only Python 2 is supported." I don't think is official
policy but I find it a useful piece of information to leave for other
readers.
Can you submit a revised patch that addresses these issues?
| [Prev in Thread] | Current Thread | [Next in Thread] |