[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHES] Upgrade Kodi to 16.0
From: |
Mathieu Lirzin |
Subject: |
Re: [PATCHES] Upgrade Kodi to 16.0 |
Date: |
Sat, 12 Mar 2016 21:10:31 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hello David,
David Thompson <address@hidden> writes:
>>From 80f08dde121610dcc832f4e6ecdd11341166580c Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Sat, 12 Mar 2016 12:23:47 -0500
> Subject: [PATCH 1/3] gnu: Add crossguid.
>
> * gnu/packages/kodi.scm (crossguid): New variable.
> ---
[...]
> +(define-public crossguid
> + (let ((commit "8f399e8bd4252be9952f3dfa8199924cc8487ca4"))
> + (package
> + (name "crossguid")
> + (version (string-append "0.0-1." (string-take commit 7)))
> + ;; There's no official release. Just a Git repository.
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/graeme-hill/crossguid.git")
> + (commit commit)))
> + (sha256
> + (base32
> + "1i29y207qqddvaxbn39pk2fbh3gx8zvdprfp35wasj9rw2wjk3s9"))))
You have omitted “(file-name (string-append name "-" version ".tar.gz"))”.
> + (build-system gnu-build-system)
Maybe ‘trivial-build-system’ would be more adapted. WDYT?
> + (arguments
> + '(#:phases
> + (modify-phases %standard-phases
> + (delete 'configure) ; no configure script
> + ;; There's no build system here, so we have to do it ourselves.
> + (replace 'build
> + (lambda _
> + (and (zero? (system* "g++" "-c" "guid.cpp" "-o" "guid.o"
> + "-std=c++11" "-DGUID_LIBUUID"))
> + (zero? (system* "ar" "rvs" "libcrossguid.a" "guid.o")))))
> + (replace 'check
> + (lambda _
> + (and (zero? (system* "g++" "-c" "test.cpp" "-o" "test.o"
> + "-std=c++11"))
> + (zero? (system* "g++" "-c" "testmain.cpp" "-o"
> "testmain.o"
> + "-std=c++11"))
> + (zero? (system* "g++" "test.o" "guid.o" "testmain.o"
> + "-o" "test" "-luuid"))
> + (zero? (system* (string-append (getcwd) "/test"))))))
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (install-file "guid.h" (string-append out "/include"))
> + (install-file "libcrossguid.a"
> + (string-append out "/lib"))
> + #t))))))
> + (inputs
> + `(("util-linux" ,util-linux)))
> + (synopsis "Lightweight GUID/UUID library")
What about using “Lightweight universal identifier library” to avoid
technical abbreviations?
> + (description "CrossGuid is a minimal GUID/UUID generator library for
> +C++.")
I think using address@hidden for GUID and UUID would be appropriate.
Could you rephrase the description to describe their usual purpose?
>>From c7a1e349381a36080fb72a31f32665be157d22fe Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Tue, 1 Mar 2016 10:04:14 -0500
> Subject: [PATCH 2/3] gnu: Add dcadec.
>
> * gnu/packages/audio.scm (dcadec): New variable.
> ---
[...]
> +
> +(define-public dcadec
> + (package
> + (name "dcadec")
> + (version "0.2.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/foo86/dcadec/archive/v"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "0i0dpypgqkhhi4v1fmsp2way6w9kbcix3c7q79pmg39yvrzj17gd"))))
Like previous patch “(file-name (string-append name "-" version ".tar.gz"))”.
>>From 11f770f17e1965ce7316a4820a1ad652f1bdc0bf Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Mon, 29 Feb 2016 21:34:00 -0500
> Subject: [PATCH 3/3] gnu: kodi: Update to 16.0.
>
> * gnu/packages/kodi.scm (kodi): Update to 16.0.
“[inputs]: Add crossguid, dcadec, and util-linux.”
Otherwise LGTM!
Thanks.
--
Mathieu Lirzin