Re: [PATCH 3/6] gnu: attic: Specify dependency on address@hidden

[Leo Famulari]

On Tue, Mar 15, 2016 at 11:58:59AM +0300, Alex Kost wrote:
> Leo Famulari (2016-03-15 02:34 +0300) wrote:
> 
> > * gnu/packages/backup.scm (attic)[inputs]: Specify dependency on
> > address@hidden
> > ---
> >  gnu/packages/backup.scm | 12 ++++++++++--
> >  1 file changed, 10 insertions(+), 2 deletions(-)
> >
> >
> > diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
> > index aa8ccbc..88b54f0 100644
> > --- a/gnu/packages/backup.scm
> > +++ b/gnu/packages/backup.scm
> > @@ -348,8 +348,16 @@ rdiff-backup is easy to use and settings have sensible 
> > defaults.")
> >      (inputs
> >       `(("acl" ,acl)
> >         ("openssl" ,openssl)
> > -       ("python-llfuse" ,python-llfuse)
> > -       ("python-msgpack" ,python-msgpack)))
> > +       ("python-msgpack" ,python-msgpack)
> > +
> > +       ;; Attic is probably incompatible with llfuse > 0.41.
> > +       ;; These links are to discussions of llfuse compatibility from
> > +       ;; the borg project. Borg is a recent fork of attic, and attic
> > +       ;; has not been updated since the fork, so it's likely that
> > +       ;; llfuse compatibility requirements are still the same.
> > +       ;; https://github.com/borgbackup/borg/issues/642
> > +       ;; https://github.com/borgbackup/borg/issues/643
> > +       ("python-llfuse" ,address@hidden)))
> 
> You use a variable address@hidden (which should be
> ‘python-llfuse-0.41’ IMO) that does not exist yet, as it will be
> introduced in the next patch.  I think you should swap patches 3 and 4.

Thank you for catching this. Fixed.

> 
> -- 
> Alex