Re: [PATCH 1/2] gnu: Add freealut.

[David Hashe]

Hi Ricardo,

Thanks for taking the time to review this!

On Mon, Mar 21, 2016 at 9:36 AM, Ricardo Wurmus <address@hidden> wrote:

Hi David,

thank you for the patch!

> * gnu/packages/audio.scm (freealut): New variable.
> ---

[...]

>
> +(define-public freealut
> +  (package
> +    (name "freealut")
> +    (version "1.1.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    ;; The official repository is defunct. This is the most
> +                    ;; popular mirror.
> +                    (url (string-append "https://github.com/vancegroup/" name))
> +                    (commit version)))

I see that Arch and Fedora both use the tarball from here:

    http://pkgs.fedoraproject.org/repo/pkgs/freealut/freealut-1.1.0.tar.gz/e089b28a0267faabdb6c079ee173664a/freealut-1.1.0.tar.gz

The advantage of that tarball is that it doesn’t require bootstrapping,
so you can do without the additional “autogen” phase and without the
three native inputs.

Done. By the way, where exactly do you find what tarball Arch and Fedora use for a given package? I couldn't seem to find that information on a cursory glance.

 

> +    (home-page "http://www.openal.org/")

Does Freealut itself have a home page?  It doesn’t seem right to me to
declare the website of OpenAL as the home page, when the package is
really just one implemenatation of the standard published on the OpenAL
website.

I agree, but it doesn't seem to have a separate home page. Debian simply lists the home page as "http://www.openal.org/", for instance. I could set the field to #f, but guix lint complains about that and it looks like only the bootstrap-binaries actually do that. For now, I've added a comment clarifying the situation.

Let me know if you think that another option would be better.

 

> +    (synopsis "OpenAL Utility Tool")

Is it a library or a tool (or both)?  What does it do?

It is a library, similar to GLUT from OpenGL. I've expanded the synopsis to "Implementation of the OpenAL Utility Toolkit (ALUT)", which I patterned off of the freeglut synopsis.

 

> +    (description "Freealut is a free implementation of OpenAL's ALUT
> +standard.")

Could you try to extend the description a little?  I don’t know what
this really means.

I've expanded the synopsis.

 

~~ Ricardo

Thanks!

David Hashe

0001-gnu-Add-freealut.patch
Description: Text Data