guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3] gnunet-gtk build-input, homepage (was Re: [PATCH] gnunet.s


From: Nils Gillmann
Subject: Re: [PATCH 3] gnunet-gtk build-input, homepage (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))
Date: Mon, 28 Mar 2016 19:42:16 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Leo Famulari <address@hidden> writes:

> On Mon, Mar 28, 2016 at 05:57:50PM +0200, Nils Gillmann wrote:
>> From ee326257b613449ca5c0834f7e8f6b8d0840d486 Mon Sep 17 00:00:00 2001
>> From: Nils Gillmann <address@hidden>
>> Date: Mon, 28 Mar 2016 17:49:27 +0200
>> Subject: [PATCH] gnu: gnunet-gtk: Add build-input and home-page.
>
> Can you split this into two patches?

I can, but why should I? Because it's two kinds of changes? I see
different grouped changes everywhere in the commit logs.

>> 
>> * gnu/packages/gnunet.scm (gnunet-gtk)[configure-flags]: Add build-input 
>> gnunet.
>> [home-page]: New value.
>> ---
>>  gnu/packages/gnunet.scm | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>> 
>> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
>> index 9fe09a2..9fa2773 100644
>> --- a/gnu/packages/gnunet.scm
>> +++ b/gnu/packages/gnunet.scm
>> @@ -316,7 +316,9 @@ services.")
>>      (arguments
>>       `(#:configure-flags
>>         (list "--without-libunique"
>> -             "--with-qrencode")))
>> +             "--with-qrencode"
>> +             (string-append "--with-gnunet="
>> +                            (assoc-ref %build-inputs "gnunet")))))
>>      (inputs
>>       `(("gnunet" ,gnunet)
>>         ("libgcrypt" ,libgcrypt)
>> @@ -327,4 +329,5 @@ services.")
>>      (native-inputs
>>       `(("pkg-config" ,pkg-config)
>>         ("libglade" ,libglade)))
>> -    (synopsis "Graphical front-end tools for GNUnet")))
>> +    (synopsis "Graphical front-end tools for GNUnet")
>> +    (home-page "https://gnunet.org";)))
>> -- 
>> 2.7.3
>> 
>
>> 
>> -- 
>> ng
>> personal contact: http://krosos.sdf.org
>> EDN: https://wiki.c3d2.de/EDN
>
>
>

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN




reply via email to

[Prev in Thread] Current Thread [Next in Thread]