Re: [PATCH] gnu: Add cgit.

[宋文武]

address@hidden (Ludovic Courtès) writes:

> 宋文武 <address@hidden> skribis:
>
>> * gnu/packages/version-control.scm (cgit): New variable.
>
> [...]
>
>> +    (arguments
>> +     '(#:tests? #f ;
>
> Please add a comment on why tests are disabled.  Better yet: fix’em!
> ;-)
It try to build a some kind of full version of git, but
failed.  (I give up on fixing it now.)

>> +    (native-inputs
>> +     `(("asciidoc" ,asciidoc)
>> +       ("xmllint" ,libxml2)
>> +       ("xsltprot" ,libxslt)))
>> +    (inputs
>> +     `(("docbook-xml" ,docbook-xml)
>> +       ("docbook-xsl" ,docbook-xsl)
>
> I would move DocBook to ‘native-inputs’.
OK, since they’re only for building the manpage.
>
>> +    (description
>> +     "CGit is an attempt to create a fast web interface for the Git SCM, 
>> using
>> +a built-in cache to decrease server I/O pressure.")
>> +    (license gpl2)))
>
> Version 2 only, right?
Yes, the source don't mention “later version”.

Pushed, thanks for review!