[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: r-devtools: Update to 1.10.0.

From: Roel Janssen
Subject: Re: [PATCH] gnu: r-devtools: Update to 1.10.0.
Date: Tue, 29 Mar 2016 14:40:30 +0200
User-agent: mu4e 0.9.17; emacs

Attachment: 0001-gnu-Add-r-withr.patch
Description: Text Data

Attachment: 0002-gnu-r-devtools-Update-to-1.10.0.patch
Description: Text Data

Hello Ricardo,

Thank you for your superfast review.

Ricardo Wurmus writes:

>> In this newer version, a new dependency was introduced (r-withr), which
>> I also added a package recipe for.
> Could you please split this into two separate patches?  One adding
> r-withr, the other updating r-devtools and adding r-withr.


>> From 30c0938b1d1239fc1a1c894d6706c4f322395a9e Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <address@hidden>
>> Date: Tue, 29 Mar 2016 14:00:57 +0200
>> Subject: [PATCH] gnu: r-devtools: Update to 1.10.0.
>> * gnu/packages/statistics.scm (r-devtools): Update to 1.10.0.
>> * gnu/packages/statistics.scm (r-withr): New variable.
> In addition to splitting these changes, please also mention that you
> added r-withr to the propagated-inputs of r-devtools.

I hope the syntax for this is correct in my new patch.

>> +(define-public r-withr
>> +  (package
>> +    (name "r-withr")
>> +    (version "1.0.1")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (cran-uri "withr" version))
>> +              (sha256
>> +               (base32
>> +                "0zbj3rd7dc0ycknmay7y7rm1qvnh9n05jw93gjggz46j2zfmy93y"))))
>> +    (build-system r-build-system)
>> +    (home-page "";)
>> +    (synopsis "Run code with temporarily modified global state")
>> +    (description
>> +     "A set of functions to run code 'with' safely and temporarily modified
>> +global state.  Many of these functions were originally a part of the 
>> 'devtools'
>> +package, this provides a simple package with limited dependencies to provide
>> +access to these functions.")
>> +    (license license:gpl2+)))
> Please try to turn the first sentence fragment into an actual sentence,
> even if it is just “This package provides [a] set of functions...”.
> Aside from that I don’t understand the first sentence.  Is “with” a
> function or a keyword?  If so, it should be wrapped in address@hidden  But
> even then I have difficulties parsing the sentence.
> The second sentence seems to be a combination of two sentences glued
> together by a comma.  This should probably be a semicolon.
> So how about this instead?
>      “This package provides a set of functions to run R code in an
>      environment in which global state has been temporarily modified.
>      Many of these functions were originally a part of the 'devtools'
>      package.”
> Thanks!

Your proposed description reads fine.  Thank you for this!  I made one
small change: 'devtools' to r-devtools, because that's the Guix package

Kind regards,
Roel Janssen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]