[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [v2 1/2] gnu: Add libbsd.
From: |
Alex Kost |
Subject: |
Re: [v2 1/2] gnu: Add libbsd. |
Date: |
Sat, 02 Apr 2016 10:47:14 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Leo Famulari (2016-04-02 04:24 +0300) wrote:
> * gnu/packages/libbsd.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> ---
> gnu-system.am | 1 +
> gnu/packages/libbsd.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 44 insertions(+)
> create mode 100644 gnu/packages/libbsd.scm
[...]
> +(define-public libbsd
> + (package
> + (name "libbsd")
> + (version "0.8.2")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://libbsd.freedesktop.org/releases/"
> + "libbsd-" version ".tar.xz"))
> + (sha256
> + (base32
> + "02i5brb2007sxq3mn862mr7yxxm0g6nj172417hjyvjax7549xmj"))))
> + (build-system gnu-build-system)
> + (synopsis "Utility functions from BSD systems")
> + (description "This library provides useful functions commonly found on
> BSD
> +systems, and lacking on others like GNU systems, thus making it easier to
> port
> +projects with strong BSD origins, without needing to embed the same code over
> +and over again on each project.")
> + (home-page "https://libbsd.freedesktop.org/wiki/")
> + (license (list bsd-2 bsd-3 bsd-4 bsd-style expat isc public-domain
> non-copyleft))))
Wow, a lot of licenses! "guix lint" reports: "invalid license field".
This happens because 'non-copyleft' is a procedure, not a license. Look
at other packages to see how it is used. Also, please don't make such
long lines. Overall it would be something like this:
(license (list bsd-2 bsd-3 bsd-4 bsd-style expat isc public-domain
(non-copyleft "file://COPYING"
"See COPYING in the distribution.")))
The rest looks good to me, thanks!
--
Alex