[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/9] gnu: fontforge: Make SVG builds reproducible.
From: |
Leo Famulari |
Subject: |
Re: [PATCH 6/9] gnu: fontforge: Make SVG builds reproducible. |
Date: |
Wed, 6 Apr 2016 13:56:57 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Apr 06, 2016 at 12:44:31PM -0500, Eric Bavier wrote:
> On 2016-04-06 12:36, Leo Famulari wrote:
> >On Tue, Apr 05, 2016 at 11:32:58PM -0500, address@hidden
> >wrote:
> >>From: Eric Bavier <address@hidden>
> >>
> >>* gnu/packages/fontutils.scm (fontforge)[source]: Add snippet to clear
> >> timestamp in svg.c.
> >>---
> >> gnu/packages/fontutils.scm | 7 ++++++-
> >> 1 file changed, 6 insertions(+), 1 deletion(-)
> >>
> >>diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> >>index 75edd55..5ca9835 100644
> >>--- a/gnu/packages/fontutils.scm
> >>+++ b/gnu/packages/fontutils.scm
> >>@@ -512,7 +512,12 @@ definitions.")
> >> ;; Make TTF builds bit-reproducible by clearing the
> >>timestamp
> >> ;; that goes in TTF files.
> >> (substitute* "fontforge/tottf.c"
> >>- (("cvt_unix_to_1904\\(now") "cvt_unix_to_1904(0"))))))
> >>+ (("cvt_unix_to_1904\\(now") "cvt_unix_to_1904(0"))
> >>+
> >>+ ;; Make SVG builds bit-reproducible by clearing the
> >>timestamp
> >>+ ;; that goes in SVG files.
> >>+ (substitute* "fontforge/svg.c"
> >>+ (("ctime\\(&now\\)") "ctime(0)"))))))
> >
> >Could you use the value of the environment variable SOURCE_DATE_EPOCH
> >instead of 0?
>
> Probably. But I'd save that for a later update, since it would be a much
> bigger change (that we could hopefully move upstream).
You could put the logic in the package definition and string-append the
value into svg.c.
If not, can you set the ctime to '1'? That is what we are using as the
value of SOURCE_DATE_EPOCH on Guix:
http://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/gnu-build-system.scm#n46
- [PATCH 2/9] gnu: Add woff-tools., (continued)
- [PATCH 7/9] gnu: Add font-fantasque-sans., ericbavier, 2016/04/06
- [PATCH 9/9] gnu: fontforge: Install 'showttf' tool., ericbavier, 2016/04/06
- [PATCH 8/9] gnu: fontforge: Use modify-phases., ericbavier, 2016/04/06
- Re: [PATCH 1/9] gnu: Add ttfautohint., Alex Kost, 2016/04/06
- Re: [PATCH 1/9] gnu: Add ttfautohint., Eric Bavier, 2016/04/06
- Specifying package patches in a more convenient form, Alex Kost, 2016/04/07
- Re: Specifying package patches in a more convenient form, Andy Wingo, 2016/04/07
- Re: Specifying package patches in a more convenient form, Eric Bavier, 2016/04/07
- Re: Specifying package patches in a more convenient form, Alex Kost, 2016/04/08
- Re: Specifying package patches in a more convenient form, Ludovic Courtès, 2016/04/09