[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] gnu: Add reposurgeon.

From: Mathieu Lirzin
Subject: Re: [PATCH 2/3] gnu: Add reposurgeon.
Date: Thu, 21 Apr 2016 17:44:54 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> Mathieu Lirzin <address@hidden> skribis:
>> * gnu/packages/version-control.scm (reposurgeon): New variable.
> [...]
>> +         (add-before 'build 'fix-docbook
>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +             (setenv "XML_CATALOG_FILE"
>> +                     (string-append (assoc-ref inputs "docbook-xsl")
>> +                                    "/xml/xsl/docbook-xsl-"
>> +                                    ,(package-version docbook-xsl)
>> +                                    "/manpages/docbook.xsl"))
> Could you add a comment on why this is needed?
> Normally, with libxml2 as an input, ‘XML_CATALOG_FILE’ should be
> properly initialized.

In fact that was not needed, so I have removed this snippet.

>> +             ;; xsltproc generates random ids when the source document 
>> doesn't
>> +             ;; provide them.  This is making the build not reproducible.
>> +             (substitute* "reposurgeon.xml"
> Eventually we should fix it in libxslt along these lines:
> Could you send an updated patch?

After some digging, I have found that the generated IDs were based on
their node pointer address in the parse tree.  So I have added an
additional patch which should be applied in the next release of libxslt.

Attachment: 0001-gnu-libxslt-Make-generated-documentation-reproducibl.patch
Description: Text Data

Attachment: 0002-gnu-Add-reposurgeon.patch
Description: Text Data

Thanks for the review.

Mathieu Lirzin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]