Re: [PATCH] Add vcflib.

[Roel Janssen]

0001-gnu-Add-tabixpp-v2.patch
Description: Text Data

Ricardo Wurmus writes:

> Roel Janssen <address@hidden> writes:
>
>> Hello Ricardo,
>>
>> Thank you for your review.
>>
>> Ricardo Wurmus writes:
>>>> +        (replace 'install
>>>> +          (lambda* (#:key outputs #:allow-other-keys)
>>>> +            (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
>>>> +              (install-file "tabix++" bin)))))))
>>>> +   (home-page "https://github.com/ekg/tabixpp";)
>>>> +   (synopsis "C++ wrapper around tabix project")
>>>
>>> “tabix” or “Tabix”?
>>
>> Tabix I suppose.
>>
>>>> +   (description "This is a C++ wrapper around the Tabix project which 
>>>> abstracts
>>>> +some of the details of opening and jumping in tabix-indexed files.")
>>>> +   (license license:expat)))
>>>
>>> “tabix” or “Tabix”?
>>
>> Right.  I changed both occurrences to “Tabix”.
>>
>>> Could you please send an updated patch?
>>
>> Here it is.
>
> Thanks, looks good, except for having the inputs before the arguments.
> I tried to apply the patch to master but it failed.  Could you please
> rebase it onto master and resend?

Attached a new patch with the inputs after arguments.

Thanks!

Kind regards,
Roel Janssen