guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tar bombs and muscle


From: Ben Woodcroft
Subject: Re: [PATCH] tar bombs and muscle
Date: Sat, 30 Apr 2016 15:48:50 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2



On 30/04/16 12:13, Leo Famulari wrote:
On Sun, Apr 24, 2016 at 10:04:01AM +1000, Ben Woodcroft wrote:
* gnu/packages/bioinformatics.scm (muscle): New variable.
+              (file-name (string-append name "-" version ".tar.gz"))
Once fetched, the source code is a directory rather than a tarball, so
I think it's best to omit the last component of the string.

+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin (string-append out "/bin")))
+               (install-file "muscle" bin)))))))
It only creates the one executable?

+    (license license:public-domain)))
Wow, they really don't make it easy to find this information. Can you
add a comment saying that it's in 'usage.cpp'? Unless I missed something
obvious...

Otherwise, looks good to me!
Pushed with those changes. Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]