Re: [PATCH] New package: Seren

[Alex Kost]

Francesco Frassinelli (2016-05-05 17:34 +0300) wrote:

> Hello,

Hello and welcome!

> I'm a new Guix user and I created a package for Seren, a P2P VoIP
> conference program which uses Opus as codec.

You made a new "seren.scm" file, but didn't add a standard header (with
copyright, license, etc.) to it.  Also new files should be registered in
"<guix>/gnu/local.mk".

However, there is no need to put this pakcage into a separate module.  I
think (gnu packages telephony) is a suitable module for it.

The commit message should look like this.

--8<---------------cut here---------------start------------->8---
gnu: Add seren.

* gnu/packages/telephony.scm (seren): New variable.
--8<---------------cut here---------------end--------------->8---

> From ecffe90a83f8ae0dddef49cfb115e28b854b5d62 Mon Sep 17 00:00:00 2001
> From: Francesco Frassinelli <address@hidden>
> Date: Thu, 5 May 2016 16:23:15 +0200
> Subject: [PATCH] Add package Seren
>
> ---
>  gnu/packages/seren.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 gnu/packages/seren.scm
>
> diff --git a/gnu/packages/seren.scm b/gnu/packages/seren.scm
> new file mode 100644
> index 0000000..8ac95ef
> --- /dev/null
> +++ b/gnu/packages/seren.scm
> @@ -0,0 +1,46 @@
> +(define-module (gnu packages seren)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix licenses)
> +  #:use-module (gnu packages linux)
> +  #:use-module (gnu packages xiph)
> +  #:use-module (gnu packages ncurses)
> +  #:use-module (gnu packages multiprecision))
> +
> +(define-public seren
> +  (package
> +    (name "seren")
> +    (version "0.0.21")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://holdenc.altervista.org/";
> +                                  "seren/downloads/seren-" version
> +                                  ".tar.gz"))
> +              (sha256
> +               (base32
> +                 "06mams6bng7ib7p2zpfq88kdr4ffril9svzc9lprkb0wjgmkglk9"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (delete 'check))))

Usually instead of deleting 'check' phase, we disable tests, so it
could look like this:

      (arguments '(#:tests? #f))  ; no "check" target

> +    (inputs `(("alsa-lib" ,alsa-lib)
> +              ("opus" ,opus)
> +              ("libogg" ,libogg)
> +              ("ncurses" ,ncurses)
> +              ("gmp" ,gmp)))
> +    (synopsis "Simple VoIP program to create conferences from the terminal")
> +    (description
> +     "Seren is a simple VoIP program based on the Opus codec that allows you
> +to create a voice conference from the terminal, with up to 10
> +partecipants, without having to register accounts, exchange emails, or
> +add people to contact lists.
> +All you need to join an existing conference is the host name or IP
> +address of one of the partecipants.
> +Seren creates a dynamic peer-to-peer network of equivalent nodes which
> +exchange text and audio data using a UDP connection, and offers the
> +user the ability to change the quality/bitrate on the fly, encrypt the
> +traffic and record the calls.")

If you want to make separate paragraphs here, use additional newlines:

    (description
     "Seren is a simple VoIP program based on the Opus codec that allows
you to create a voice conference from the terminal, with up to 10
partecipants, without having to register accounts, exchange emails, or
add people to contact lists.

All you need to join an existing conference is the host name or IP
address of one of the partecipants.

Seren creates a dynamic peer-to-peer network of equivalent nodes which
exchange text and audio data using a UDP connection, and offers the user
the ability to change the quality/bitrate on the fly, encrypt the
traffic and record the calls.")

(Though I think this description is a bit long, but it's probably OK)

> +    (home-page "http://holdenc.altervista.org/seren/";)
> +    (license gpl3+)))

The rest looks good to me, could you send an updated patch?
And thanks for contributing!

-- 
Alex