Re: HTTP server invalid date header

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> Ludovic Courtès <address@hidden> writes:
>
>> Ricardo Wurmus <address@hidden> skribis:
>>
>>> Ludovic Courtès <address@hidden> writes:
>>>
>>>> Ricardo Wurmus <address@hidden> skribis:
>>>>
>>>>> I tested JUnit previously with the log4j-api package, but I cannot
>>>>> submit this right now due to a bug(?) in Guile’s HTTP client, which
>>>>> makes it impossible for me to download the sources of its dependencies,
>>>>> such as this one:
>>>>>
>>>>>     
>>>>> http://central.maven.org/maven2/org/osgi/org.osgi.core/6.0.0/org.osgi.core-6.0.0-sources.jar
>>>>>     ERROR: Bad Date header: Wed, 30 Jul 2014  3:47:42 GMT
>>>>
>>>> ISTR you were working on a workaround for this issue.  What’s the
>>>> status?
>>>
>>> I got it fixed (after wasting a lot of time wondering why it would not
>>> work as I had patched the wrong file), but the fix isn’t really pretty.
>>
>> [...]
>>
>>> From c98ca436bafe8077edaf3125b529ea32fbd48611 Mon Sep 17 00:00:00 2001
>>> From: Ricardo Wurmus <address@hidden>
>>> Date: Fri, 29 Apr 2016 22:12:24 +0200
>>> Subject: [PATCH] build: Accept dates with space-padded hour field.
>>>
>>> * guix/build/download.scm: Replace "parse-rfc-822-date" from the (web
>>>   http) module.
>>
>> I don’t think it’s worse than the original.  ;-)
>>
>> To help maintenance, could you make sure there’s a Guile bug number for
>> this one?  And then you can submit this change to Guile itself, and
>> after that backport it to Guix (with a reference to the Guile bug and
>> commit.)
>>
>> Would that work for you?
>
> Sure, no problem.  The bug I submitted to bug-guile received number
> 23421.  I already submitted my patch to guile-devel, but it seems to be
> stuck in the queue for now.  Once it has been committed I’ll backport
> the change to Guix.

Fixed in Guile commit 16050431f29d56f80c4a8253506fc851b8441840 (not a
great fix due to limitations in the ‘string-match?’ macro there.)

The backport will probably require a copy of both ‘string-match?’ and
‘parse-rfc-822-date’.

Thanks,
Ludo’.