Re: [PATCH] gnu: Add emacs-clojure-mode

[Catonano]

2016-05-19 10:54 GMT+02:00 Alex Kost <address@hidden>:

> Subject: gnu: Add emacs-clojure-mode
                                      ^
This is a nitpick of course, but we put a period here...

> * gnu/packages/emacs.scm (emacs-clojure-mode): New variable
                                                             ^
... and here.

Do you mean like this ?

Subject: gnu: Add emacs-clojure-mode.

* gnu/packages/emacs.scm (emacs-clojure-mode): New variable.

 

> +(define-public emacs-clojure-mode
> +  (package
> +    (name "emacs-clojure-mode")
> +    (version "5.3.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/clojure-emacs/clojure-mode.git")
> +             (commit "8ef7127da214cb7fd4b47fc943462f2a8bfb8f85")))

Is there a reason to use 'git-fetch'?  I think a usual 'url-fetch' is
fine as there is:
<https://github.com/clojure-emacs/clojure-mode/archive/5.3.0.tar.gz>.

No, there's no specific reason. Fixed it.

> +       (file-name (string-append name "-" version "-checkout"))
> +       (sha256
> +        (base32
> +          "1x7nl5wzcah9hnlj5jfd3y5604w60zcqcw1nn6vw335c2vzzissj"))))
> +    (build-system emacs-build-system)
> +    (home-page "http://github.com/clojure-emacs/clojure-mode")
> +    (synopsis "Major mode for Clojure code")
> +    (description
> +     "Provides font-lock, indentation, navigation and basic refactoring for the

We use full sentences for descriptions, like this: "This emacs package
provides ..."

Fixed
 

> +Clojure programming language (http://clojure.org).

Since we use texinfo to format descriptions, it is better to write:

  @uref{http://clojure.org, Clojure programming language}

Fixed
 

> +
> +Using clojure-mode with paredit or smartparens is highly recommended.

I think this description is too verbose.  I would remove all the text
below.

Ok, I cut it.

So, I edited the patch and attached it again.

Would you see if it fits ?

Thanks

0001-gnu-Add-emacs-clojure-mode.patch
Description: Text Data