[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add hdf4
From: |
Leo Famulari |
Subject: |
Re: [PATCH] gnu: Add hdf4 |
Date: |
Mon, 23 May 2016 14:17:19 -0400 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Mon, May 23, 2016 at 06:22:09PM +0100, Jeremy Robst wrote:
Welcome, and thanks for the patch!
Unfortunately, I can't seem to apply it to my source tree. Is anybody
else able to do so? I can't figure *why* it doesn't apply. Jeremy, are
you able to apply it with `patch -p1` or `git am`?
> +(define-public hdf4
> + (package
> + (name "hdf4")
> + (version "4.2.11")
> + (source + (origin + (method url-fetch)
This is strange. It renders as expected once the patch is downloaded,
but in Mutt, it looks like this. I wonder if this has to do with the
patch not applying?
> + (arguments '(#:tests? #f))
We prefer to add a comment explaining why test are disabled. If there
are no tests, then the comment can be "No test suite."
> + (license (license:x11-style
> +
> "https://www.hdfgroup.org/ftp/HDF/HDF_Current/src/unpacked/COPYING"))))
To me, this looks more like a variation on the BSD license than the x11
license. Perhaps non-copyleft is a more appropriate choice. Can you look
at some of our packages using non-copyleft and report back?
Can you look into these questions and send an updated patch?
- [PATCH] gnu: Add hdf4, Jeremy Robst, 2016/05/23
- Re: [PATCH] gnu: Add hdf4,
Leo Famulari <=
- Re: [PATCH] gnu: Add hdf4, Jeremy Robst, 2016/05/24
- Re: [PATCH] gnu: Add hdf4, Eric Bavier, 2016/05/24
- Re: [PATCH] gnu: Add hdf4, Jeremy Robst, 2016/05/25
- Re: [PATCH] gnu: Add hdf4, Leo Famulari, 2016/05/27
- Re: [PATCH] gnu: Add hdf4, Ludovic Courtès, 2016/05/28
- Re: [PATCH] gnu: Add hdf4, Jeremy Robst, 2016/05/29
- Re: [PATCH] gnu: Add hdf4, Ludovic Courtès, 2016/05/29