guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]:Resend: Add LLVM, clang and clang-runtime-3.8 to GNU Guix


From: Dennis Mungai
Subject: Re: [PATCH]:Resend: Add LLVM, clang and clang-runtime-3.8 to GNU Guix
Date: Thu, 26 May 2016 23:44:35 +0300

See corrected patch, as attached.



On 26 May 2016 at 23:13, Roel Janssen <address@hidden> wrote:
> Hello Dennis,
>
> Welcome and thank you for the patch.
>
> Dennis Mungai writes:
>
>> +(define-public llvm-3.8
>> +  (package (inherit llvm)
>> +    (version "3.8.0")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "http://llvm.org/releases/";
>> +                           version "/llvm-" version ".src.tar.xz"))
>> +       (sha256
>> +        (base32
>> +         "0ikfq0gxac8xpvxj23l4hk8f12ydx48fljgrz1gl9xp0ks704nsm"))))
>> +    (native-inputs
>> +     `(("python" ,python-wrapper)
>> +       ("perl"   ,perl)
>> +       ("libffi" ,libffi)
>> +       ("zlib" ,zlib)))
>
> One space between the string and the unquote is enough.
>
>> +    (arguments
>> +     `(#:configure-flags '("-DCMAKE_SKIP_BUILD_RPATH=FALSE"
>> +                           "-DCMAKE_BUILD_WITH_INSTALL_RPATH=FALSE"
>> +                           "-DLLVM_ENABLE_PIC=ON"
>> +                           ;"-DLLVM_ENABLE_RTTI=ON"
>> +                           "-DLLVM_ENABLE_WERROR=OFF"
>> +                           ;;"-DLLVM_REQUIRES_RTTI=ON"
>
> Could you remove the options you commented out?
>
>> +                           )))))
>
> These should be positioned directly after "-DLLVM_ENABLE_WERROR=OFF".
>
>> +
>> +(define-public clang-runtime-3.8
>> +  (clang-runtime-from-llvm
>> +   llvm-3.8
>> +   "1c2nkp9563873ffz22qmhc0wakgj428pch8rmhym8agjamz3ily8"))
>> +
>> +(define-public clang-3.8
>> +  (clang-from-llvm llvm-3.8 clang-runtime-3.8
>> +                   "1ybcac8hlr9vl3wg8s4v6cp0c0qgqnwprsv85lihbkq3vqv94504"))
>> --
>> 2.7.4
>
> Thank you,
> Roel Janssen

Attachment: add-llvm-3.8.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]