[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add googletest
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Add googletest |
Date: |
Wed, 01 Jun 2016 09:47:47 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Leo Famulari <address@hidden> skribis:
> On Tue, May 31, 2016 at 08:53:17AM -0500, Lukas Gradl wrote:
[...]
>> + (replace 'install
>> + (lambda _
>> + (let ((out (assoc-ref %outputs "out")))
>> + (and
>> + (mkdir-p (string-append out "/lib"))
>> + (mkdir-p (string-append out "/include"))
>> + (zero?
>> + (system* "cp" "-r"
>> + "../googletest-release-1.7.0/include"
>> + out))
>> + (zero? (system* "cp" "libgtest.a" "libgtest_main.a"
>> + (string-append out "/lib"))))))))))
>
> I think these uses of (system*) could be replaced by (copy-recursively)
> and (install-file), respectively.
s/could/should/ even ;-)
Ludo’.
- Re: [PATCH] Add googletest, Efraim Flashner, 2016/06/01
- Re: [PATCH] Add googletest,
Ludovic Courtès <=
- Re: [PATCH] Add googletest, Lukas Gradl, 2016/06/01
- Re: [PATCH] Add googletest, Leo Famulari, 2016/06/01
- Re: [PATCH] Add googletest, Lukas Gradl, 2016/06/02
- Re: [PATCH] Add googletest, Efraim Flashner, 2016/06/05
- Re: [PATCH] Add googletest, Lukas Gradl, 2016/06/05
- Re: [PATCH] Add googletest, Efraim Flashner, 2016/06/09
- Re: [PATCH] Add googletest, Lukas Gradl, 2016/06/09