Re: [PATCH] gnu: Add guile-gnome

[David Pirotte]

Hello,

Le Tue, 07 Jun 2016 13:57:19 -0400,
Patrick Hetu <address@hidden> a écrit :

> Ludovic Courtès @ 2016-05-28 12:06 EDT:
> 
> > Pushed as 9b381643f009025d97dfc0b82d2c00800c204380 with a few minor
> > changes:
> >  
> >> +(define-public guile-g-wrap  
> >
> > This one is already available in (gnu packages guile).  :-)  
> 
> Oops, I was looking for guile-g-wrap instead of g-wrap...
> 
> Still, the current g-wrap package needs a new patch to fix his Makefile.in
> because the native-search-paths hooks won't find it for Guile 2.0.

Note that I don't develop neither [yet] use guix [shame on me], but I  don't
understand why you should change anything wrt Makefile(s):

        from http://www.nongnu.org/g-wrap/download.html, Notes 3.

        "... G-Wrap's modules will be installed in $prefix/share/guile/site. If 
it
        differs from Guile's global site directory, then this path must be 
added to
        Guile's load paths before to use G-Wrap and compile Guile-Gnome or
        Guile-Clutter. ..."

Note that G-wrap compiles and runs fine with both Guile-2.0 and 2.2.  So if Guix
installs G-wrap using the same prefix as the one used for guile, which I 
recommend,
then nothing needs to be changed since guile's default %load-path already 
include
(%global-site-dir), and unless $prefix would differ for guix guile-2.0 and
guile-2.2, [hopefully there are the same?], then users can always fire guile
and: ,use (g-wrap), independently from which guile version they are using.

My 2c, but as I [administratively] maintain g-wrap, feedback welcome.

> Also, should I rename it to guile-g-wrap at the same time?

IMO, it's better to keep the original name, which in this case is G-wrap

        http://www.nongnu.org/g-wrap/

Cheers,
David

pgpJ_SfA2FAz7.pgp
Description: OpenPGP digital signature