[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Update python2-qrcode (refactored)
From: |
Ben Woodcroft |
Subject: |
Re: [PATCH] gnu: Update python2-qrcode (refactored) |
Date: |
Fri, 17 Jun 2016 08:08:08 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
Hi Daniel,
Thanks for the patch.
Subject: [PATCH 3/3] gnu: Add python2-qrcode
nitpicks: A full stop should be added at the end, and the following
changelog-style line should be added:
* gnu/packages/python.scm (python2-qrcode): New variable.
There was also some trailing whitespace in the patch.
+
+(define-public python2-qrcode
+ (package
+ (name "python2-qrcode")
+ (version "5.1")
5.3 is the newest version, is there a reason to stick with this older
version?
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://pypi.python.org/packages/source/q/qrcode/qrcode-"
+ version ".tar.gz"))
I think Andreas' comment still applies here i.e. better to use 'pypi-url'.
+ (sha256
+ (base32
+ "0skzrvhjnnacrz52jml4i050vdx5lfcd3np172srxjaghdgfxg9k"))))
+ (build-system python-build-system)
+ (inputs
+ `(("python2-setuptools" ,python2-setuptools)
Can we make this a native-input ?
+ ("python2-pillow" ,python2-pillow)
I agree this should be an input, even if it is optional. However, it
does not get included in the .pth file, does this mean that it is not
available as usual in an environment. Would you mind please checking this?
+ ("python2-six" ,python2-six)))
+ (arguments
+ `(#:python ,python-2)) ; only Python 2.7 is supported
+ (home-page "https://pypi.python.org/pypi/qrcode")
+ (synopsis "Python library to generate QR Codes")
+ (description
+ "Python library that uses image libraries, Python Imaging
Library (PIL)
+by default, to generate QR Codes.")
How about "qrcode is a library which can be used to generate Quick
Response (QR) images. It is recommended that the pillow library be used
to generate images, though the default Python imaging library can also
be used.
+ (license license:expat)))
This should be bsd-3 I think.
Thanks,
ben
- [PATCH] gnu: Add python2-qrcode, Daniel Pimentel, 2016/06/14
- Re: [PATCH] gnu: Add python2-qrcode, ng0, 2016/06/14
- Re: [PATCH] gnu: Update python2-qrcode (refactored), Daniel Pimentel, 2016/06/16
- Re: [PATCH] gnu: Update python2-qrcode (refactored),
Ben Woodcroft <=
- Re: [PATCH 2/2] gnu: Update python2-qrcode, Daniel Pimentel, 2016/06/17
- Re: [PATCH 2/2] gnu: Update python2-qrcode, Ben Woodcroft, 2016/06/18
- Re: [PATCH 2/2] gnu: Update python2-qrcode, Daniel Pimentel, 2016/06/23
- [PATCH] gnu: Add python2-qrcode, Daniel Pimentel, 2016/06/23
- Re: [PATCH] gnu: Add python2-qrcode, Ben Woodcroft, 2016/06/23
- Re: [PATCH 2/2] gnu: Update python2-qrcode, Daniel Pimentel, 2016/06/17