[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: guix: python-build-system: Change pypi-uri to use https://p

From: Ben Woodcroft
Subject: Re: [PATCH]: guix: python-build-system: Change pypi-uri to use
Date: Fri, 24 Jun 2016 09:51:56 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0

On 23/06/16 21:39, 宋文武 wrote:
Leo Famulari <address@hidden> writes:

On Wed, Jun 22, 2016 at 01:35:17PM -0500, Christopher Allan Webber wrote:
Note that the old URL scheme no longer seemed to work.

I'm not thrilled by the new URL "scheme".  It seems like more work to
update with each version bump.  I'm not sure what the solution is?
Please review Ben's 'pypi-origin' patch :)

      (source (origin
                (method url-fetch)
-              (uri (pypi-uri "Flask" version))
+              (uri
+               (string-append
+                "";
+                "78e165d30f0c8bb5d57c429a30ee5749825ed461ad6c959688872643ffb3/"
+                "Flask-0.11.1.tar.gz"))
In the meantime, I think it's best to keep the hash on its own line, to
reduce noise in the commit log if we do more updates in this format.
Ah, nixpkgs use for it, and it will redirect the old uri
scheme to the new one.

I guess we should do the same?

This is a simpler solution than 'pypi-origin'. Thanks.

My only concern is that it is "pre-production", WDYT?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]