[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add fontconfig-path-max.

From: rennes
Subject: Re: [PATCH] gnu: Add fontconfig-path-max.
Date: Tue, 12 Jul 2016 09:25:49 -0500
User-agent: Roundcube Webmail/1.0.6


I issue the command on GNU/Linux and GNU Hurd:

  ./pre-inst-env guix build fontconfig -K

and compile correctly. How I do manual testing?

On 2016-07-12 09:08, address@hidden wrote:

Please see
regarding commit logs.  :-)

Reviewed and corrected in the patch.

+--- a/src/fcstat.c
++++ b/src/fcstat.c
+@@ -278,7 +278,8 @@ FcDirChecksum (const FcChar8 *dir, time_t *checksum)
+       {
+ #endif
+       struct stat statb;
+-      char f[PATH_MAX + 1];
++      int size = 128;
++      char *f = malloc (size);

This is not OK, in part because it introduces a memory leak.  The fix
should be along the same lines as the rest of the patch.

As you suggested, I used the same logic to make this part of patch.

Could you check whether Debian has a patch for a more recent version of

The version (2.11.0-6.3) is the last version, and not contain a patch
for fcstat.c file. It is possible that the Debian team has not had
problems with this file to compile.

There is a Workaround that suggests mailing lists freedesktop.

Thanks for the comments.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]