[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] WIP: Output linters

From: ericbavier
Subject: [PATCH] WIP: Output linters
Date: Tue, 12 Jul 2016 23:34:32 -0500

From: Eric Bavier <address@hidden>

I very much appreciate all that 'guix lint' can do, and thought that we could
get some benefit from extending its coverage to package outputs.  I wanted to
share this WIP patch to get some feedback on the idea.

The current patch just adds a simple check for the presence of build directory
strings in the output, which may affect build reproducibility across machines.
Other checks that might be useful might include checks:

* for "recent" timestamps, which might indicate use of __DATE__ or `date`,

* for presence of '.DIR' or other empty directories,

* for proper placement of documentation,

* for documentation that might best be moved to a "doc" output, or

* for self-contained pkg-config files, etc.

Any such checks obviously rely on the package outputs being in the store.  On
the one hand both local builds and substitutes are expensive.  But on the
other hand we'd like 'guix lint' to be run before someone submits a patch or
pushes their commits.  Being a good submitter, they hopefully went through the
trouble to test that the package builds, so the package outputs are mostly
likely in the store anyhow, and 'guix lint' wouldn't have any extra work to

I'd like to hear from others whether they think this WIP has enough merit to
include in 'guix lint', and if so what other checks might be worth including.

Eric Bavier (1):
  gnu: lint: Check package outputs.

 guix/scripts/lint.scm | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]