[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-

From: Ludovic Courtès
Subject: Re: [PATCH 1/4] lint: Add packages with suffix ':bin' to 'inputs-should-be-native'.
Date: Thu, 21 Jul 2016 18:06:32 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Vincent Legoll <address@hidden> skribis:

> On Thu, Jul 21, 2016 at 2:24 PM, Ludovic Courtès <address@hidden> wrote:
>> David Craven <address@hidden> skribis:
>>>> I think packages with a “bin” output are not always used as native
>>>> inputs, so I would drop this rule.
>>> From searching the code-base we have I couldn't find a counter example. Do
>>> you think it's ok to check for glib:bin specifically?
>> Yes, sounds good to me.
>> However, make sure to match on the package name + output, not on the
>> label.  That is, ‘lint’ should correctly diagnose something like:
>>   (inputs `(("somethingsilly" ,glib "bin")))
> Yes, this is very important, as you have newbies coming now that try to
> package software for guix and they don't understand what they are doing.
> :-)
> I was wondering the other day, what this "somethingsilly" string is for,
> is it just a string or does it need to be a reference to something not 
> silly...

This "somethingsilly" is just a label that allows you to refer to an
input on the build side, in idioms like:

  (assoc-ref inputs "somethingsilly")
  => "/gnu/store/…-glib-42.0-bin"

This predates g-expressions, which solve this problem more elegantly.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]