[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] gnu: Add lrzip.

From: Ludovic Courtès
Subject: Re: [PATCH v2] gnu: Add lrzip.
Date: Sat, 23 Jul 2016 12:45:07 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Hi Tobias,

address@hidden (Ludovic Courtès) skribis:

> Tobias Geerinckx-Rice <address@hidden> skribis:
>> On 2016-07-21 22:24, Tobias Geerinckx-Rice wrote:
>>> +    (native-inputs
>>> +     `(,@(if (string-prefix? "i686" (or (%current-target-system)
>>> +                                        (%current-system)))
>>> +             `(("nasm" ,nasm))
>>> +             '())
>> Hmm. Not sure where this falls on the ‘let the code speak for itself’
>> to ‘should have added a comment’ scale.
>> Guess I'll wait for another review + patch or a very friendly committer.
> I have another idea: could you create a Savannah account and tell me
> your user name?  :-)

I’ve added you to the Savannah group so you can commit directly.

Please see the ‘HACKING’ file on how to be a good citizen.  ;-)
In particular, make sure to configure commit signing as noted at

So I think the last iteration of this patch, with a comment regarding
the i686 case as you wrote above, will be a good thing to push.

Happy hacking!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]