[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] lint: 'inputs-should-be-native' checks for intltool, itstool

From: Ludovic Courtès
Subject: Re: [PATCH] lint: 'inputs-should-be-native' checks for intltool, itstool and glib:bin.
Date: Sun, 24 Jul 2016 19:57:29 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

David Craven <address@hidden> skribis:

> * guix/scripts/lint.scm (check-inputs-should-be-native): Warn when intltool,
> itstool or glib:bin isn't a native-input.
> * tests/lint.scm (inputs: glib:bin is probably a native input): Add test.



> +      (((labels packages . outputs) ...)
> +        (for-each (lambda (package output)
> +          (when (package? package)
> +            (let ((input (string-append
> +                    (package-name package)
> +                    (if (> (length output) 0)
> +                      (string-append ":" (car output)) ""))))

Identation was misleading, so I’ve fixed that.

> +              (when (member input native-inputs)
> +                (emit-warning package
> +                  (string-append input " should probably be a native 
> input"))))))

Here ‘package’ was referring to the input rather than to the package
being linted, so I’ve fixed that; I also switched to ‘format’ and made
sure the string is internationalized.

Pushed as 99fe215cc1c511a82e326727c6a0d193d246a387, thank you!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]