[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] import: pypi: Compute test requirements when reading req
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 4/5] import: pypi: Compute test requirements when reading requirements files. |
Date: |
Mon, 25 Jul 2016 23:12:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Cyril Roelandt <address@hidden> skribis:
> On 07/22/2016 11:30 PM, Ludovic Courtès wrote:
>> This seems to suggest that this could be factorized somehow. Maybe
>> unpack once and read the two files at once?
>
> The problem is that both files might not be there, and unzip will return
> a non-zero exit code if any of them is missing, so it seems easier to
> just run unzip twice. WDYT?
OK, I see. Then what about adding a procedure like:
(define (file-from-zip-archive archive file)
"Return the contents of FILE from ARCHIVE as a string, or #f if FILE
could not be found in ARCHIVE or extraction failed."
;; … invoke unzip in temporary dir, check return code, then:
(call-with-input-file (string-append tempdir "/" file)
get-string-all))
That would move the bits about exit codes and all that out of the main
logic.
WDYT?
Thanks,
Ludo’.
[PATCH 4/5] import: pypi: Compute test requirements when reading requirements files., Cyril Roelandt, 2016/07/16
[PATCH 3/5] import: pypi: Compute test requirements when using wheels., Cyril Roelandt, 2016/07/16
[PATCH 5/5] import: pypi: Add more tests., Cyril Roelandt, 2016/07/16
Re: [PATCH 0/5] Improve the pypi updater., Hartmut Goebel, 2016/07/17
Re: [PATCH 0/5] Improve the pypi updater., Ludovic Courtès, 2016/07/22