[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 15/16] gnu: Add perl-mail-spf.

From: Danny Milosavljevic
Subject: Re: [PATCH v4 15/16] gnu: Add perl-mail-spf.
Date: Thu, 28 Jul 2016 22:54:30 +0200

On Thu, 28 Jul 2016 19:55:39 +0000
ng0 <address@hidden> wrote:

> This one lacks the bsd-3 in the licenses in the header of mail.scm. I
> fixed this locally for now as I'm new to reviewing 16 dependent patches.
> I also got this message while running make on the root of guix checkout:
> gnu/packages/tls.scm:547:4: warning: possibly unbound variable 
> `perl-crypt-openssl-random'

Yes, I forgot to include this one (sorry). I'm new to huge patch series like 
this too...

I can add it in v5.

> gnu/packages/mail.scm:1296:4: warning: possibly unbound variable `perl-uri'
> Possibly caused by some other file already loading perl.scm module.

No, because perl-uri is in web.scm . 
mail.scm should import web.scm . I forgot that as well.

So - to summarize - the header of mail.scm should also:
- add bsd-3 license
- import web.scm

reply via email to

[Prev in Thread] Current Thread [Next in Thread]