[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 22/22] gnu: Add roary.

From: Leo Famulari
Subject: Re: [PATCH 22/22] gnu: Add roary.
Date: Fri, 29 Jul 2016 17:07:46 -0400
User-agent: Mutt/1.6.0 (2016-04-01)

On Wed, Jul 27, 2016 at 10:54:23PM +1000, Ben Woodcroft wrote:
> * gnu/packages/bioinformatics.scm (roary): New variable.

Wow, this is a complicated package! Thanks for doing the work!

> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'delete-bundled-binaries
> +           (lambda _
> +             (delete-file-recursively "binaries")
> +             #t))

The only thing I would suggest you change is to delete these binaries in
an origin snippet. The effect would be that the binaries would not be
provided by `guix build --source roary`.

If the binaries aren't provided with their source code, then I think
this change is required.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]