Re: isnan, isinf in ldc; Was: Re: Release imminent

[Leo Famulari]

On Wed, Aug 03, 2016 at 11:12:34AM +0200, Andreas Enge wrote:
> Hi Danny,
> 
> On Wed, Aug 03, 2016 at 09:51:10AM +0200, Danny Milosavljevic wrote:
> > ldc fails because they do
> >   ::isnan
> > which is a bad idea if isnan is a C macro (which it usually isn't - but hey 
> > O_o). I've substituted
> >   isnan
> > for it and this part then compiles fine.
> > This fix is not safe in general because if there's a method called isnan in 
> > scope, it will use that. In the ldc case, they've named the method "isNan" 
> > - so it's fine.
> 
> did you forget to add a patch?
> 
> Anyway, they made a release 1.0.0. Maybe it would be preferable to try
> an update of the package first, in case the problem is already solved
> on their side?

I prefer this approach. Always try to take upstream's solution :)