Re: [PATCH] update notmuch and python bindings

[ng0]

ng0 <address@hidden> writes:

> Troy Sankey <address@hidden> writes:
>
>> Updated patches address all comments so far except for the removal of
>> the emacs input.  Also updated the test numbers just for fun.
>>
>> Quoting ng0 (2016-08-07 18:24:57)
>>> I'd also advise to upgrade git to something more recent if your distro
>>> allows it :)
>>
>> Debian stable :)  It's a long term project of mine to switch to GuixSD.
>> I'm switching over one package at a time.  Next is notmuch!
>
> Maybe git 2.9.x is in backports.. I'm just pointing this out because
> recently someone told me about security issues with certain versions of
> git.
>
>>> I'll try to test build tomorrow morning when my buildserver is up
>>> again. release notes read interesting enough. thanks for the patches.
>>
>> Thanks.
>>
>> Troy

The patches build, the practical part I can not review, reading the
CHANGELOG I assume it to work this way, but someone else should review
this.

>> From 034a4ac3b1bc85ae574fbe9f79add609cf311cc1 Mon Sep 17 00:00:00 2001
>> From: Troy Sankey <address@hidden>
>> Date: Sun, 7 Aug 2016 13:21:28 -0400
>> Subject: [PATCH 1/3] gnu: notmuch: Update to 0.22.1.
>>
>> This also removes the emacs input.  Quote from the notmuch NEWS file:
>>
>>   Drop dependency on "pkg-config emacs".

I don't feel good about this commit message, I would rather write:

gnu: notmuch: Update to 0.22.1.

* gnu/packages/mail.scm (notmuch): Update to 0.22.1.
(notmuch)[inputs]: Remove emacs.


Or something like this.

What do you think?
-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org