Re: [PATCH] Add surfraw (needs review).

[ng0]

ng0 <address@hidden> writes:

> Hi,
>
> shouldn't packages built by guix end up with guixbuilder:guixbuilder and
> not root:root for owner and group? Surfraw ends up as root:root in
> store. I think this might be the reason why it does not find its global
> config.
>
> address@hidden /gnu/store/cgjb171snxlm1fm5i2qjkj4id1mx2q8f-surfraw-2.2.9/bin$ 
> ./surfraw -elvi ddg asdf
> surfraw ERROR: couldn't find global config in 
> /gnu/store/cgjb171snxlm1fm5i2qjkj4id1mx2q8f-surfraw-2.2.9/etc/xdg/surfraw/conf
>  or $XDG_CONFIG_DIRS
> address@hidden /gnu/store/cgjb171snxlm1fm5i2qjkj4id1mx2q8f-surfraw-2.2.9/bin$ 
> ./surfraw --help
> surfraw ERROR: couldn't find global config in 
> /gnu/store/cgjb171snxlm1fm5i2qjkj4id1mx2q8f-surfraw-2.2.9/etc/xdg/surfraw/conf
>  or $XDG_CONFIG_DIRS
> address@hidden /gnu/store/cgjb171snxlm1fm5i2qjkj4id1mx2q8f-surfraw-2.2.9/bin$ 
> ./surfraw --version
> surfraw ERROR: couldn't find global config in 
> /gnu/store/cgjb171snxlm1fm5i2qjkj4id1mx2q8f-surfraw-2.2.9/etc/xdg/surfraw/conf
>  or $XDG_CONFIG_DIRS
> address@hidden /gnu/store/cgjb171snxlm1fm5i2qjkj4id1mx2q8f-surfraw-2.2.9/bin$ 
> ./surfraw -v
> surfraw ERROR: couldn't find global config in 
> /gnu/store/cgjb171snxlm1fm5i2qjkj4id1mx2q8f-surfraw-2.2.9/etc/xdg/surfraw/conf
>  or $XDG_CONFIG_DIRS
>
> I also asked upstream if there have been enough commits for a new
> release (most recent one was in December 2013)
>
> From b0355420897e9a751edd4e2a43ca7415b3b29d6e Mon Sep 17 00:00:00 2001
> From: ng0 <address@hidden>
> Date: Sun, 14 Aug 2016 10:33:18 +0000
> Subject: [PATCH] gnu: Add surfraw.
>
> * gnu/packages/web.scm (surfraw): New variable.
> ---
>  gnu/packages/web.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 9106295..2b35d27 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -3389,3 +3389,30 @@ playback of HTTP request/response traces.")
>  can easily be invoked on a single file.  Your partner can access the file 
> with
>  tools they trust (e.g. wget).")
>      (license l:gpl2+)))
> +
> +(define-public surfraw
> +  (package
> +    (name "surfraw")
> +    (version "2.2.9")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://surfraw.alioth.debian.org/dist/";
> +                                  name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1fy4ph5h9kp0jzj1m6pfylxnnmgdk0mmdppw76z9jhna4jndk5xa"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags
> +       ;; The opensearch elvis depends on the perl libraries WWW::OpenSearch,
> +       ;; HTML::Parser and LWP (libwww-perl). We do not have all of lwp 
> packaged,
> +       ;; therefore disable building opensearch as it is not essential to 
> surfraw.

This is wrong, it seems like I just need to package WWW::OpenSearch.

> +       (list "--disable-opensearch")))
> +    (inputs
> +     `(("perl" ,perl)))
> +    (synopsis "Unix command line interface to the www")
> +    (description "Surfraw (Shell Users' Revolutionary Front Rage Against the 
> Web)
> +provides a unix command line interface to a variety of popular www search 
> engines
> +and similar services.")
> +    (home-page "https://surfraw.alioth.debian.org/";)
> +    (license l:public-domain)))
> -- 
> 2.9.2
>
>
> -- 
> ♥Ⓐ  ng0
> For non-prism friendly talk find me on http://www.psyced.org

-- 
♥Ⓐ  ng0
For non-prism friendly talk find me on http://www.psyced.org