[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/24] gnu: xorg: Add lndir.

From: Alex Kost
Subject: Re: [PATCH 08/24] gnu: xorg: Add lndir.
Date: Wed, 17 Aug 2016 20:49:22 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

David Craven (2016-08-17 11:35 +0300) wrote:

>> The patch looks good to me, except the indentation of this
>> (string-append ...).  I usually write 'source' fields like this:
>>    (source (origin
>>              (method url-fetch)
>>              (uri (string-append "mirror://xorg/individual/util/lndir-"
>>                                  version ".tar.bz2"))
>>              (sha256
>>               (base32
>>                "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
>> But this is not a big deal, of course :-)
> I prefer
> (uri (string-append
>         "mirror://xorg/individual/util/"
>         "lndir-" version ".tar.bz2"))

OK, but then it should be (note the indentation of 'string-append'):

  (uri (string-append
        "lndir-" version ".tar.bz2"))

> But in this case I thought that keeping consistent with how it was
> done in the xorg.scm file was more important than my preference. What
> do you think?

Many (probably most) packages in xorg.scm have bad indentation.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]