Re: [PATCH] gnu: Add eschalot.

[ng0]

Leo Famulari <address@hidden> writes:

> On Fri, Aug 26, 2016 at 03:49:36PM +0000, ng0 wrote:
>> TL;DR: only run the test suite if you own a cluster, super computer or
>> otherwise much computation power which will be bored by this
>> hashing. Everyone else will spend MANY hours on this, which is why make
>> check/test is disabled.
>
> How many is MANY? ;)

Well, take a look at the build computer specs, compare to either
eschalot or scalion data on how long hashing takes for the names
generated into the wordfile and you will see why the eschalot page
itself has a <ctrl>-c in the example output of running the test, and
why running the tests is not part of the default phases.

>> +;; There is no release candidate but commits point out a version number.
>> +(define-public eschalot
>> +  (let ((commit "0bf31d88a11898c19b1ed25ddd2aff7b35dbac44")
>> +        (revision "1"))
>> +    (package
>> +      (name "eschalot")
>> +      (version (string-append "1.2.0-" revision "." (string-take commit 7)))
>> +               (url "https://github.com/schnabear/eschalot";)
>
> I think this is okay.
>
>> +      ;; Licenses are various as eschalots cites the applications it was 
>> based on
>> +      ;; or which it was influenced by, eschalot author says the 
>> application itself
>> +      ;; is under a BSD license, the combination of all could be seen as 
>> expat or
>> +      ;; a variation of such.  It is not clear.  FIXME: Specify license(s) 
>> used.
>> +      (license (license:non-copyleft
>> +                "file://LICENSE"
>> +                "See LICENSE in the distribution for the licenses which 
>> apply.")))))
>
> It uses the ISC license and the Expat license.

Alright, I'll update the patch. thanks for reviewing.
-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org