[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add p7zip.

From: Ricardo Wurmus
Subject: Re: [PATCH] gnu: Add p7zip.
Date: Sun, 04 Sep 2016 16:31:48 +0200
User-agent: mu4e 0.9.16; emacs 25.1.1

Hi Kei,

> Ricardo Wurmus <address@hidden> writes:
>> Kei Kebreau <address@hidden> writes:
>>> Ricardo Wurmus <address@hidden> writes:
>>>> Kei Kebreau <address@hidden> writes:
>>>>> Whoops, last patch was a bit messy and stacked on the previous one. This
>>>>> patch should be better!
>>>> I just wanted to push a slightly modified version of this (attached) but
>>>> I cannot actually build the package.  The patch to remove unused code
>>>> does not apply due to different line endings.
>>>> Could you please take a look at this again and make sure that the patch
>>>> to the sources applies?
>>>> ~~ Ricardo
>>> I just tried it on my machine, and everything applied and built
>>> correctly from a clean Guix tree. I don't exactly know how to proceed
>>> From here. Perhaps a third party can try to build from the patch?
>> The problem might be with the inline patch in the email.  Don’t know.
>> ~~ Ricardo
> I'll try sending it again, for lack of a better plan. If all else fails
> I can post it on

I fetched the unpatched sources, initialised a fresh git repo, then
partially applied the patch, then fixed the errors, then regenerated the
patch and compared it to your patch.  Turns out that all of the lines in
the two failed hunks end on 0x0d0a, but in your patch this doesn’t
happen, hence the error messages.

I pushed the amended commit to master as

~~ Ricardo

reply via email to

[Prev in Thread] Current Thread [Next in Thread]