[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] gnu: Add filteraudio.
From: |
Efraim Flashner |
Subject: |
Re: [PATCH 2/3] gnu: Add filteraudio. |
Date: |
Thu, 8 Sep 2016 11:40:52 +0300 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Wed, Sep 07, 2016 at 09:00:01PM -0400, Erik Edrosa wrote:
> * gnu/packages/audio.scm (filteraudio): New variable.
> ---
> gnu/packages/audio.scm | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 40cc029..4a6f400 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -2483,3 +2483,34 @@ with support for HD extensions.")
> flavors EBU R128, ATSC A/85, and ReplayGain 2.0. It helps normalizing the
> loudness of audio and video files to the same level.")
> (license license:gpl2+)))
> +
> +(define-public filteraudio
> + (let ((revision "1")
> + (commit "2fc669581e2a0ff87fba8de85861b49133306094"))
> + (package
> + (name "filteraudio")
> + (version (string-append "0.0.0-" revision "."
> + (string-take commit 7)))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/irungentoo/filter_audio.git")
> + (commit commit)))
here you also need to declare (file-name
> + (sha256
> + (base32
> + "0hbb290n3wb23f2k692a6bhc23nnqmxqi9sc9j15pnya8wifw64g"))))
> + (build-system gnu-build-system)
> + (arguments
> + '(#:make-flags (list (string-append "PREFIX=" %output)
> + "CC=gcc")
> + #:tests? #f
Please add a comment explaining why no tests, even if it is just 'no
test target'
> + #:phases
> + (alist-delete
> + 'configure
> + %standard-phases)))
It may be shorter in this case, but we've still switched to 'modify-phases'
> + (synopsis "Lightweight audio filtering library")
> + (description "An easy to use audio filtering library made from webrtc
> code, used
> +in @code{libtoxcore}.")
> + (home-page "https://github.com/irungentoo/filter_audio")
> + (license license:bsd-3))))
> --
> 2.10.0
>
>
Looks good! Can you send a revised patch with the changes listed?
--
Efraim Flashner <address@hidden> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature