Re: [PATCH] gnu: Add python-gunicorn and python2-gunicorn.

[Leo Famulari]

On Sun, Sep 11, 2016 at 10:50:35PM +0200, Hartmut Goebel wrote:
> * gnu/packages/web.scm (python-gunicorn, python2-gunicorn): New
>   variables.

Thanks for this! Regarding the naming question, I think it's fine to
call it 'gunicorn'. Prefixing with 'python-' is more appropriate for
libraries and other "helper" packages, whereas user facing or standalone
applications can use the plain upstream name, in my opinion.

See the manual, section 7.6.5 Python Modules, for a little bit of
guidance.

> +         (add-before 'check 'remove-requirements
> +           ; setup.py reads test-requirements from a file which is
> +           ; pinning to other versions then guix provides. This also
> +           ; enforces optional packages like pytst-cov. So clean the
> +           ; list.
> +           (lambda _
> +             (substitute* "requirements_test.txt"
> +               ((".*") "")))))))
> +    (native-inputs
> +     `(("python-pytest" ,python-pytest)
> +       ;("python-pytest-cov" ,python-pytest-cov) ; optional

I think we should either use pytest-cov or remove this commented line.
What do you think?

> +(define-public python2-gunicorn
> +  (let ((base (package-with-python2
> +               (strip-python2-variant python-gunicorn))))
> +    ; Note: byte-compiling gunicorn/workers/_gaiohttp.py with Python 2
> +    ; fails, but this module will be available for Python 3 only
> +    ; anyway.

Can you elaborate on this? Does python2-gunicorn still work? If so,
okay.