[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/7] Add bioconductor package creation tools.
From: |
Leo Famulari |
Subject: |
Re: [PATCH 0/7] Add bioconductor package creation tools. |
Date: |
Sat, 17 Sep 2016 19:52:04 -0400 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Thu, Sep 15, 2016 at 01:37:47PM +0200, Roel Janssen wrote:
> In the following patch series I add packages to do package development
> for Bioconductor. They have a couple of tools to perform extra checks
> to ensure Bioconductor packages work together well.
>
> Since I am trying to add a package to Bioconductor, I need these
> packages in GNU Guix. I've been using them for a couple of days and
> it seems to work fine.
The packages look straightforward to me.
My only suggestion would be to change the descriptions to begin with
"$package is a ..." rather than "This package ...". I think it's useful
to have the package name in the description. Perhaps some of the
descriptions could give more detail, but I'm not familiar with this
software, so I can't say.
I think that if they are working for you, you've done a license audit,
and they pass `guix lint`, then they are okay.