[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install argument.
From: |
Danny Milosavljevic |
Subject: |
Re: [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install argument. |
Date: |
Mon, 26 Sep 2016 14:39:26 +0200 |
Hi David,
On Mon, 26 Sep 2016 12:34:46 +0200
David Craven <address@hidden> wrote:
> (define-public u-boot-vexpress
> - (make-u-boot-package "vexpress_ca9x4" "arm-linux-gnueabihf"))
> + (make-u-boot-package "vexpress_ca9x4" "arm-linux-gnueabihf"
> '("u-boot.bin")))
>
> (define-public u-boot-malta
> - (make-u-boot-package "malta" "mips64el-linux-gnuabi64"))
> + (make-u-boot-package "malta" "mips64el-linux-gnuabi64" '("u-boot.bin")))
>
> (define-public u-boot-beagle-bone-black
> - (make-u-boot-package "am335x_boneblack" "arm-linux-gnueabihf"))
> + (make-u-boot-package "am335x_boneblack" "arm-linux-gnueabihf" '("MLO"
> "u-boot.img")))
^^^^
Ughh... are we sure we want to do that? I don't think a regular user would know
what to put there. If the U-Boot build is from a clean slate it's not like
there are stray files lying around or anything - we can just copy them all if
we want.
Also, I don't think that we will have these define-public things for different
systems in the long run. I posted a generated patch adding *all* of the
supported U-Boot systems and Ludo vetoed it (and I agree by now - it's not
necessary).
My preferred approach would be to allow the user to put the following into
/etc/config.scm :
(bootloader (u-boot-configuration
(device "/dev/mmcblk0")
(package (make-u-boot-package "malta")))
(Nothing was left off)
What do you think?
- [PATCH 1/6] gnu: Add picocom., David Craven, 2016/09/26
- [PATCH 3/6] gnu: make-linux-libre: Install device tree files., David Craven, 2016/09/26
- [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install argument., David Craven, 2016/09/26
- Re: [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install argument.,
Danny Milosavljevic <=
- Re: [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install argument., David Craven, 2016/09/26
- Re: [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install argument., David Craven, 2016/09/26
- Re: [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install argument., Danny Milosavljevic, 2016/09/26
- Re: [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install argument., David Craven, 2016/09/26
- Re: [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install argument., Danny Milosavljevic, 2016/09/26
[PATCH 2/6] gnu: %default-extra-linux-options: Remove redundant options., David Craven, 2016/09/26