[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/12] gnu: Add rustc-bootstrap.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 10/12] gnu: Add rustc-bootstrap. |
Date: |
Mon, 26 Sep 2016 12:24:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
David Craven <address@hidden> skribis:
> * gnu/packages/rust.scm (rustc-bootstrap): New variable.
[...]
> +(define-public rustc-bootstrap
> + (package
> + (name "rustc-bootstrap")
> + (version "1.12.0")
> + (source rust-bootstrap-x86_64-1.12.0)
Could you add a comment above that summarizes the bootstrapping story
that Eric Le Bihan and others discussed about here, and/or give a link
to that discussion?
> + (inputs
> + `(("gcc-lib" ,gcc "lib")
> + ("gcc-toolchain-6" ,gcc-toolchain-6)
I think we can omit “-6” and use the current default. However could you
add a comment as to why we depend on gcc-toolchain and provide that “cc”
symlink? I’m sure Eric L.B. explained it before, but I forgot.
> + (platform ,(system->rust-platform (%current-system)))
I don’t see ‘system->rust-platform’ defined here. I think it’d be best
in the importer or in the build system.
> + (description "Rustc bootstrap.")
Could you expound a bit?
Thanks for picking it up!
Ludo’.
- Re: [PATCH 12/12] gnu: Add rust helper functions., (continued)
- [PATCH 06/12] import: Add importer for rust crates., David Craven, 2016/09/22
- [PATCH 04/12] import: utils: Add spdx-string->license., David Craven, 2016/09/22
- [PATCH 08/12] build-system: Add cargo build system., David Craven, 2016/09/22
- [PATCH 10/12] gnu: Add rustc-bootstrap., David Craven, 2016/09/22
- Re: [PATCH 10/12] gnu: Add rustc-bootstrap.,
Ludovic Courtès <=
- Re: [PATCH 01/12] import: Move json-fetch to (guix import utils)., Eric Bavier, 2016/09/22