Re: [PATCH] gnu: Add hdf-eos5.

[Ludovic Courtès]

Hi Thomas,

Thomas Danckaert <address@hidden> skribis:

> you were right, there was a lot of room to simplify.  This patch
> modifies autotools' generated files, so there's no need for autoreconf
> anymore.
>
> In the meantime, I discovered that the library can also build a
> Fortran wrapper.  I enabled this wrapper, but some of the Fortran
> tests contain some bugs (multi-line string formatting errors).  Fixing
> those tests requires a rather long (but simple) patch.  Alternatively,
> disabling the tests (or the Fortran wrapper) would shorten the patch.

Cool.

> From: address@hidden (Ludovic Courtès)
> Subject: Re: [PATCH] gnu: Add hdf-eos5.
> Date: Mon, 03 Oct 2016 17:59:14 +0200
>
>> Also, for each patch, could you add a word stating what the upstream
>> status is, such as the URL of the upstream commit or discussion,
>> when it
>> exists?
>
> The patches related to actual bugs (fortrantests, fix-szip) were
> reported to the maintainer (The library is maintained for there's no
> public bugtracker, but a contact address in the documentation), and
> might be included in a future release.
>
> I didn't submit patches related to the shared build and removal of
> bundled GCTP, as I didn't think they would be interested to take up
> such “big” changes.

Makes sense.

> From 481d66b1178fdd539111ee54233c9dcc0376d986 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <address@hidden>
> Date: Fri, 17 Jun 2016 10:51:38 +0200
> Subject: [PATCH] gnu: Add hdf-eos5.
>
> * gnu/packages/maths.scm (hdf-eos5): New variable.
> * gnu/packages/patches/hdf-eos5-build-shared.patch: New file.
> * gnu/packages/patches/hdf-eos5-remove-gctp.patch: New file.
> * gnu/packages/patches/hdf-eos5-fix-szip.patch: New file.
> * gnu/packages/patches/hdf-eos5-fortrantests.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add patches.

Applied.  I modified the ‘license’ field and added a comment after
checking what’s going on: their web page doesn’t say much, but all the
source files carry a lax license notice like this:

  ----------------------------------------------------------------------------
  |    Copyright (c) 1999  Emergent IT Inc.  and Raytheon Systems Company    |
  |                                                                          |
  |  Permission to use, modify, and distribute this software and its         |
  |  documentation for any purpose without fee is hereby granted, provided   |
  |  that the above copyright notice appear in all copies and that both that |
  |  copyright notice and this permission notice appear in supporting        |
  |                          documentation.                                  |
  ----------------------------------------------------------------------------

Thank you!

Ludo’.